Handle Expired TWAP and not started TWAP #153
Merged
+136
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
anxolin
changed the title
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @cowprotocol/[email protected] |
mfw78
approved these changes
Aug 30, 2023
alfetopito
approved these changes
Aug 30, 2023
anxolin
force-pushed
the
smarter-twap-indexing
branch
from
de95d05 to
9f59dde
Compare
anxolin
force-pushed
the
smarter-twap-indexing
branch
from
9f59dde to
4a11e0f
Compare
|
Merging as this is already too big. Lets keep iterating |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Includes some optional blockInfo params
This params allow the
pollmethod to use either theblockNumberor theblockTimestampto validate the concrete Conditional Order.Validate start time
It will check if the order started. If it haven't then we can signal we don't want to re-check until the start time
Handle Expired TWAPs
This is causing a lot of noise in the logs. Expired TWAP orders are never deleted. Now they are
Tried it in WatchTower (adapted it in cowprotocol/watch-tower#16)
Don't fail to handle errors
Handled errors should not show as errors
Not included
Left some notes for a future PR on something that will help to reduce significantly the number of checks we need to do.
It's out of scope cause is not a trivial change. It will need a model update in watch tower